Messages in this thread | | | Date | Fri, 13 Jan 2023 15:50:04 +0000 | From | Matthew Wilcox <> | Subject | Re: [PATCH -next 7/7] mm: swap: remove unneeded cgroup_throttle_swaprate() |
| |
On Thu, Jan 12, 2023 at 04:30:06PM +0800, Kefeng Wang wrote: > All the callers of cgroup_throttle_swaprate() are converted to > folio_throttle_swaprate(), so make __cgroup_throttle_swaprate() > to take a folio, and drop unused cgroup_throttle_swaprate().
Shouldn't __cgroup_throttle_swaprate() then be called __folio_throttle_swaprate()?
> +extern void __cgroup_throttle_swaprate(struct folio *folio, gfp_t gfp_mask);
Also you can drop the 'extern'.
> +static inline void folio_throttle_swaprate(struct folio *folio, gfp_t gfp_mask)
And it's not a gfp mask. It's gfp_flags (we have this mistake all through the mm). Or you can just call it 'gfp'.
| |