Messages in this thread | | | Date | Wed, 11 Jan 2023 15:14:05 +0000 | Subject | Re: [PATCH v3 2/7] perf: Use perf_pmu__open_file() and perf_pmu__scan_file() | From | James Clark <> |
| |
On 11/01/2023 07:09, Leo Yan wrote: > On Tue, Jan 03, 2023 at 04:20:36PM +0000, James Clark wrote: >> Remove some code that duplicates existing methods. This requires that >> some consts are removed because one of the existing helper methods takes >> a struct perf_pmu instead of a name which has a non const name field. >> But except for the tests, the strings were already non const. >> >> No functional changes. > > [...] > >> diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h >> index 2f2bb0286e2a..8f39e2d17fb1 100644 >> --- a/tools/perf/util/pmu.h >> +++ b/tools/perf/util/pmu.h >> @@ -2,6 +2,7 @@ >> #ifndef __PMU_H >> #define __PMU_H >> >> +#include <bits/types/FILE.h> > > Nitpick: it's good to use <stdio.h> to replace <bits/types/FILE.h>. > > Either way, this patch looks good to me:
Looks like I also forgot to update the commit message about removing the consts after the last change. Will update both in the next change.
Thanks for the review!
> > Reviewed-by: Leo Yan <leo.yan@linaro.org>
| |