Messages in this thread | | | Date | Wed, 11 Jan 2023 10:51:22 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 3/5] driver core: make struct device_type.uevent() take a const * |
| |
On Wed, Nov 23, 2022 at 01:38:05PM +0100, Rafael J. Wysocki wrote: > On Wed, Nov 23, 2022 at 1:25 PM Greg Kroah-Hartman > <gregkh@linuxfoundation.org> wrote: > > > > The uevent() callback in struct device_type should not be modifying the > > device that is passed into it, so mark it as a const * and propagate the > > function signature changes out into all relevant subsystems that use > > this callback. > > > > Cc: Jens Axboe <axboe@kernel.dk> > > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > > Cc: Len Brown <lenb@kernel.org> > > Cc: Stefan Richter <stefanr@s5r6.in-berlin.de> > > Cc: Wolfram Sang <wsa@kernel.org> > > Cc: Alexandre Belloni <alexandre.belloni@bootlin.com> > > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > Cc: Sean Young <sean@mess.org> > > Cc: Mauro Carvalho Chehab <mchehab@kernel.org> > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Frank Rowand <frowand.list@gmail.com> > > Cc: Maximilian Luz <luzmaximilian@gmail.com> > > Cc: Hans de Goede <hdegoede@redhat.com> > > Cc: Mark Gross <markgross@kernel.org> > > Cc: Vinod Koul <vkoul@kernel.org> > > Cc: Bard Liao <yung-chuan.liao@linux.intel.com> > > Cc: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > > Cc: Sanyog Kale <sanyog.r.kale@intel.com> > > Cc: Andreas Noever <andreas.noever@gmail.com> > > Cc: Michael Jamet <michael.jamet@intel.com> > > Cc: Mika Westerberg <mika.westerberg@linux.intel.com> > > Cc: Yehezkel Bernat <YehezkelShB@gmail.com> > > Cc: Jiri Slaby <jirislaby@kernel.org> > > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com> > > Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org> > > Cc: "Martin K. Petersen" <martin.petersen@oracle.com> > > Cc: Chaitanya Kulkarni <kch@nvidia.com> > > Cc: Ming Lei <ming.lei@redhat.com> > > Cc: Jilin Yuan <yuanjilin@cdjrlc.com> > > Cc: Alan Stern <stern@rowland.harvard.edu> > > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Cc: Sakari Ailus <sakari.ailus@linux.intel.com> > > Cc: Jason Gunthorpe <jgg@ziepe.ca> > > Cc: Thomas Gleixner <tglx@linutronix.de> > > Cc: Ira Weiny <ira.weiny@intel.com> > > Cc: Dan Williams <dan.j.williams@intel.com> > > Cc: Won Chung <wonchung@google.com> > > Cc: alsa-devel@alsa-project.org > > Cc: devicetree@vger.kernel.org > > Cc: linux-acpi@vger.kernel.org > > Cc: linux-block@vger.kernel.org > > Cc: linux-i2c@vger.kernel.org > > Cc: linux-i3c@lists.infradead.org > > Cc: linux-input@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: linux-media@vger.kernel.org > > Cc: linux-serial@vger.kernel.org > > Cc: linux-usb@vger.kernel.org > > Cc: linux1394-devel@lists.sourceforge.net > > Cc: platform-driver-x86@vger.kernel.org > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> > > (which my ACPI maintainer hat on).
thanks for the review, I'll add it to the v2 patch.
greg k-h
| |