Messages in this thread | | | From | Doug Anderson <> | Date | Tue, 10 Jan 2023 10:13:13 -0800 | Subject | Re: [PATCH] drm/msm/dsi: Drop the redundant fail label |
| |
Hi,
On Mon, Jan 9, 2023 at 6:50 PM Jiasheng Jiang <jiasheng@iscas.ac.cn> wrote: > > @@ -1954,9 +1949,8 @@ int msm_dsi_host_init(struct msm_dsi *msm_dsi) > > msm_host->irq = irq_of_parse_and_map(pdev->dev.of_node, 0); > if (msm_host->irq < 0) { > - ret = msm_host->irq; > dev_err(&pdev->dev, "failed to get irq: %d\n", ret); > - return ret; > + return msm_host->irq;
The dev_err() is no longer printing the right value of "ret" above.
Other than that this looks reasonable to me. Feel free to add my Reviewed-by tag once the above bug is fixed.
-Doug
| |