Messages in this thread | | | From | "Yu, Fenghua" <> | Subject | RE: [PATCH 01/18] x86/resctrl: Track the closid with the rmid | Date | Tue, 10 Jan 2023 18:01:49 +0000 |
| |
Hi, James,
> >> a/arch/x86/kernel/cpu/resctrl/monitor.c > >> b/arch/x86/kernel/cpu/resctrl/monitor.c > >> index efe0c30d3a12..f1f66c9942a5 100644 > >> --- a/arch/x86/kernel/cpu/resctrl/monitor.c > >> +++ b/arch/x86/kernel/cpu/resctrl/monitor.c > >> @@ -25,6 +25,7 @@ > >> #include "internal.h" > >> > >> struct rmid_entry { > >> + u32 closid; > > > > Could you please add a comment for this closid field? It's expected to be form > x86 RMID entry. > > So it's deserved a comment to explain a bit more on this field. > > Sure ... what does it need to convey? > I'm not sure what you mean by "expected to be form x86 RMID entry".
My typo, should be "not expected".
> > My medium verbosity version looks like this: > | /* > | * Some architectures's resctrl_arch_rmid_read() needs the CLOSID value > | * in order to access the correct monitor. This field provides the > | * value to list walkers like __check_limbo(). On x86 this is ignored. > | */ > > > Does this cover it?
Looks good to me.
Thanks.
-Fenghua
| |