Messages in this thread | | | From | JeeHeng Sia <> | Subject | RE: [PATCH v2 3/3] RISC-V: Add arch functions to support hibernation/suspend-to-disk | Date | Tue, 10 Jan 2023 07:00:38 +0000 |
| |
> -----Original Message----- > From: Conor Dooley <conor@kernel.org> > Sent: Tuesday, 10 January, 2023 3:46 AM > To: Andrew Jones <ajones@ventanamicro.com> > Cc: JeeHeng Sia <jeeheng.sia@starfivetech.com>; paul.walmsley@sifive.com; > palmer@dabbelt.com; aou@eecs.berkeley.edu; linux- > riscv@lists.infradead.org; linux-kernel@vger.kernel.org; Leyfoon Tan > <leyfoon.tan@starfivetech.com>; Mason Huo > <mason.huo@starfivetech.com> > Subject: Re: [PATCH v2 3/3] RISC-V: Add arch functions to support > hibernation/suspend-to-disk > > On Mon, Jan 09, 2023 at 08:36:24PM +0100, Andrew Jones wrote: > > On Mon, Jan 09, 2023 at 02:24:07PM +0800, Sia Jee Heng wrote: > > > > To enable hibernation/suspend to disk into RISCV, the below config > > > need to be enabled: > > > - CONFIG_ARCH_HIBERNATION_HEADER > > > - CONFIG_ARCH_HIBERNATION_POSSIBLE > > > - CONFIG_ARCH_RV64I > > > - CONFIG_64BIT > > > What's blocking this for being for both 32-bit and 64-bit? > > Just from checking with b4 diff, it's because I told them they broke the > rv32 build with their v1 implementation. > > I'd rather they fixed whatever the issue was with rv32 than ignored it. The main reason is because I don't have a rv32 system to verify the rv32 hibernation. I can submit another patch to support rv32 hibernation once I have the system or someone who has the rv32 system can submit the patch ontop. > > Thanks, > Conor.
| |