Messages in this thread | | | From | Liam Howlett <> | Subject | Re: [PATCH] mm.h: Fix "mm: Add temporary vma iterator versions of vma_merge(), split_vma(), and __split_vma() | Date | Tue, 10 Jan 2023 14:14:29 +0000 |
| |
* Andrew Morton <akpm@linux-foundation.org> [230109 18:15]: > On Mon, 9 Jan 2023 20:53:22 +0000 Liam Howlett <liam.howlett@oracle.com> wrote: > > > The extern definition of __split_vma() was removed too early. Re-add it > > and remove it once the users are all converted. > > I think I sorted this out. > > __split_vma() can be made static to mmap.c?
Ah, I don't think so? SeongJae reported an issue that I caused by dropping this definition from the header before mm/madvise.c was updated to use the alternative. I think it needs to be in the header and so it should just probably be there until the function is dropped entirely later in the series.
| |