Messages in this thread | | | Date | Tue, 10 Jan 2023 18:38:07 +0800 | Subject | Re: [PATCH v6 1/7] perf vendor events arm64: Add common topdown L1 metrics | From | Jing Zhang <> |
| |
在 2023/1/9 下午10:58, John Garry 写道: > On 09/01/2023 02:53, Jing Zhang wrote: >> I'll factor out the pmu_core__find function in tools/perf/arch/arm64/util/pmu.c: >> >> static const struct perf_pmu *pmu_core__find(void) > > maybe name as pmu_core__find_same() or similar to indicate that we're only dealing with homogeneous cores > >> { >> struct perf_pmu *pmu = NULL; > > no need to init to NULL > >> >> while ((pmu = perf_pmu__scan(pmu))) { > > 1x superfluous level of () >
Ok, will do, Thank you!
| |