lkml.org 
[lkml]   [2023]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] fat: Fix return value of vfat_bad_char() and vfat_replace_char() functions
Date
Pali Rohár <pali@kernel.org> writes:

> These functions returns boolean value not wide character.
>
> Signed-off-by: Pali Rohár <pali@kernel.org>

Thanks.

Acked-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

> ---
> fs/fat/namei_vfat.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/fat/namei_vfat.c b/fs/fat/namei_vfat.c
> index 21620054e1c4..0735e4f0aeed 100644
> --- a/fs/fat/namei_vfat.c
> +++ b/fs/fat/namei_vfat.c
> @@ -200,7 +200,7 @@ static const struct dentry_operations vfat_dentry_ops = {
>
> /* Characters that are undesirable in an MS-DOS file name */
>
> -static inline wchar_t vfat_bad_char(wchar_t w)
> +static inline bool vfat_bad_char(wchar_t w)
> {
> return (w < 0x0020)
> || (w == '*') || (w == '?') || (w == '<') || (w == '>')
> @@ -208,7 +208,7 @@ static inline wchar_t vfat_bad_char(wchar_t w)
> || (w == '\\');
> }
>
> -static inline wchar_t vfat_replace_char(wchar_t w)
> +static inline bool vfat_replace_char(wchar_t w)
> {
> return (w == '[') || (w == ']') || (w == ';') || (w == ',')
> || (w == '+') || (w == '=');

--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

\
 
 \ /
  Last update: 2023-03-26 23:34    [W:0.052 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site