lkml.org 
[lkml]   [2023]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 03/16] dt-bindings: spi: Add spi peripheral specific property
    On Mon, Jan 09, 2023 at 12:18:09PM -0800, William Zhang wrote:

    > This setting is set per spi message for particular chip select of the device
    > when starting the message through bcm63xx_hsspi_set_clk function and restore
    > to default(clock gating) when message is done through
    > bcm63xx_hsspi_restore_clk_gate.

    In that case I am extremely confused about what the feature is supposed
    to do. The description says:

    + brcm,no-clk-gate:
    + $ref: /schemas/types.yaml#/definitions/flag
    + description:
    + Some SPI device such as Broadcom ISI based voice daughtercard requires
    +SPI
    + clock running even when chip select is deasserted. By default the
    + controller turns off or gate the clock when cs is not active to save
    + power. This flag tells the controller driver to keep the clock running
    + when chip select is not active.


    which to me sounds like the clock should never be turned off and instead
    left running at all times. Switching back to clock gating after sending
    the message doesn't seem to correspond to the above at all, the message
    being done would normally also be the point at which chip select is
    deasserted.
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2023-03-26 23:35    [W:2.787 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site