lkml.org 
[lkml]   [2023]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/7] rust: sync: add `Arc` for ref-counted allocations
    On Tue, Jan 10, 2023 at 01:36:25PM -0800, Boqun Feng wrote:
    > On Tue, Jan 10, 2023 at 10:20:50PM +0100, Peter Zijlstra wrote:
    > > On Tue, Jan 10, 2023 at 12:22:47PM -0800, Boqun Feng wrote:
    > >
    > > > First, I'd really appreciate it that Will, Peter or Mark can take a look
    > > > at the series and see if they are happy or not ;-)
    > >
    > > I only have 1 patch, and since I don't speak rust I have very limited
    > > feedback. Having to use out-of-line functions seems sub-optimal, but
    > > I suppose that's a limitation of the Rust-C bindings.
    > >
    > > Afaict this is like C++ shared_ptr<> and using refcount_t seems okay for
    > > that, not sure what else you're asking.
    > >
    >
    > Thanks! I failed to find that you were only Cc for the first patch.. I
    > cannot speak for Wedson, but the rest of the patchset are all based on
    > the first patch and purely in Rust, maybe he was avoiding to "spam" your
    > inbox ;-)
    >
    > While we are at it, for a general case, say we provide Rust's interface
    > of task/kthread managament, do you prefer to seeing the whole patchset
    > (including how Rust side provides the APIs) or seeing only the patch
    > that interacts with C?
    >
    > Again, trying to find the sweet spot for collaboration ;-)

    Always all patches. The more effort I need to do to find sometihng the
    smaller the chance I will. Also, I get so much email, I've long since
    given up on reading it all.

    \
     
     \ /
      Last update: 2023-03-26 23:35    [W:3.715 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site