lkml.org 
[lkml]   [2023]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v3 3/3] riscv: dts: starfive: Add TRNG node for VisionFive 2
    Date


    > -----Original Message-----
    > From: Conor Dooley <conor@kernel.org>
    > Sent: 10 January, 2023 3:37 PM
    > To: JiaJie Ho <jiajie.ho@starfivetech.com>
    > Cc: Olivia Mackall <olivia@selenic.com>; Herbert Xu
    > <herbert@gondor.apana.org.au>; Rob Herring <robh+dt@kernel.org>;
    > Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Emil Renner
    > Berthing <kernel@esmil.dk>; Conor Dooley <conor.dooley@microchip.com>;
    > linux-crypto@vger.kernel.org; devicetree@vger.kernel.org; linux-
    > kernel@vger.kernel.org; linux-riscv@lists.infradead.org
    > Subject: RE: [PATCH v3 3/3] riscv: dts: starfive: Add TRNG node for VisionFive
    > 2
    >
    > >> Which clock source is this? I see syscrg and aoncrg in the v3
    > >> devicetree:
    > >> https://lore.kernel.org/linux-riscv/20221220011247.35560-7-
    > >> hal.feng@starfivetech.com/
    > >>
    > >> Have a missed a patchset which adds support for this particular clock
    > >> controller? At the very least, I don't think one has reached the
    > >> linux-riscv mailing list.
    > >> The clock driver patchset only has aoncrg & syscrg:
    > >> https://lore.kernel.org/linux-riscv/20221220005054.34518-1-
    > >> hal.feng@starfivetech.com/
    > >>
    > >
    > >Hi Conor,
    > >
    > >Thanks for reviewing the patches.
    > >Yes, the patch for stg domain hasn't been submitted yet.
    > >In this case should I drop this patch from the series until the related patches
    > reach the mailing list?
    >
    > Since it doesn't apply anyway, no harm keeping it IMO.
    > Having the dts can make it easier, although not in this case, to look at the
    > binding and driver.
    > Just mention it in the cover letter if/when you send another version.
    >

    Sure, I'll do this.

    Thanks,
    Jia Jie
    \
     
     \ /
      Last update: 2023-03-26 23:34    [W:4.037 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site