Messages in this thread | | | Date | Fri, 9 Sep 2022 10:43:17 -0100 | From | Melissa Wen <> | Subject | Re: build failure of next-20220906 due to 396369d67549 ("drm: vkms: Add support to the RGB565 format") |
| |
On 09/07, Sudip Mukherjee wrote: > On Wed, Sep 7, 2022 at 8:23 PM Melissa Wen <mwen@igalia.com> wrote: > > > > On 09/07, Sudip Mukherjee wrote: > > > Hi Melissa, > > > > > > On Wed, Sep 7, 2022 at 6:05 PM Melissa Wen <mwen@igalia.com> wrote: > > > > > > > > On 09/06, Sudip Mukherjee wrote: > > > > > On Tue, Sep 6, 2022 at 4:59 PM Sudip Mukherjee (Codethink) > > > > > <sudipm.mukherjee@gmail.com> wrote: > > > > > > > > > > > > Hi All, > > > > > > > > > > > > The builds of next-20220906 fails for mips, xtensa and arm allmodconfig. > > > > > > > > > > > > The errors in mips and xtensa are: > > > > > > > > > > > > ERROR: modpost: "__divdi3" [drivers/gpu/drm/vkms/vkms.ko] undefined! > > > > > > ERROR: modpost: "__udivdi3" [drivers/gpu/drm/vkms/vkms.ko] undefined! > > > > > > > > > > > > The error in arm is: > > > > > > > > > > > > ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/vkms/vkms.ko] undefined! > > > > > > ERROR: modpost: "__aeabi_ldivmod" [drivers/gpu/drm/vkms/vkms.ko] undefined! > > > > > > > > > > > > > > > > > > Trying to do a git bisect to find out the offending commit. > > > > > > > > > > git bisect points to 396369d67549 ("drm: vkms: Add support to the > > > > > RGB565 format") > > > > > > > > Hi Sudip, > > > > > > > > Thanks for pointing out this issue. > > > > > > > > I think we can replace the macros that are triggering those compilation > > > > error by functions in drm/drm_fixed.h that do the same calculation. > > > > > > > > I checked those errors when building for arm and i386 and the issues are > > > > fixed after applying the patch below. I appreciate if you can test. > > > > > > Sorry, could not test as the downloaded mbox is saying patch is > > > corrupted and could not be applied. Can you please attach the patch or > > > maybe send using git send-email. > > > > Sorry, my bad. It's attached. Let me know if goes smoothly. > > Thanks. That was perfect. > And with that I can confirm I don't see the failure on mips and arm. > Not tested on xtensa but should be fixed there also. > > Tested-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Thanks for testing it.
Melissa > > > -- > Regards > Sudip [unhandled content-type:application/pgp-signature] | |