lkml.org 
[lkml]   [2022]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH v2] powerpc: select HAVE_PATA_PLATFORM in PPC instead of creating a PPC dependency
    On Fri, Sep 9, 2022 at 1:09 PM Arnd Bergmann <arnd@arndb.de> wrote:
    >
    > On Fri, Sep 9, 2022, at 11:03 AM, Lukas Bulwahn wrote:
    > > Commit cc18e0fea790 ("LIBATA: Add HAVE_PATA_PLATFORM to select
    > > PATA_PLATFORM driver") introduces config HAVE_PATA_PLATFORM, and expects
    > > that all architectures simply select this config when the architecture
    > > supports using the PATA_PLATFORM driver.
    > >
    > > This is properly implemented already for all architectures except for the
    > > powerpc architecture. Implement this for powerpc now.
    > >
    > > Adjust the config of the powerpc architecture to use the config
    > > HAVE_PATA_PLATFORM and simplify the config PATA_PLATFORM to not mention
    > > any specific architecture anymore.
    > >
    > > Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
    > > ---
    > > arch/powerpc/Kconfig | 1 +
    > > drivers/ata/Kconfig | 2 +-
    > > 2 files changed, 2 insertions(+), 1 deletion(-)
    > >
    > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
    > > index 39d71d7701bd..2575e21b6e6b 100644
    > > --- a/arch/powerpc/Kconfig
    > > +++ b/arch/powerpc/Kconfig
    > > @@ -237,6 +237,7 @@ config PPC
    > > select HAVE_MOD_ARCH_SPECIFIC
    > > select HAVE_NMI if PERF_EVENTS || (PPC64 && PPC_BOOK3S)
    > > select HAVE_OPTPROBES
    > > + select HAVE_PATA_PLATFORM
    > > select HAVE_PERF_EVENTS
    > > select HAVE_PERF_EVENTS_NMI if PPC64
    > > select HAVE_PERF_REGS
    >
    > I don't see a single powerpc machine that creates a
    > name="pata_platform" platform_device. I suspect this was
    > only needed bwfore 2007 commit 9cd55be4d223 ("[POWERPC] pasemi:
    > Move electra-ide to pata_of_platform"), so the "|| PPC"
    > bit should just get removed without adding the HAVE_PATA_PLATFORM
    > bit.
    >

    Thanks for your investigation. I will send a corresponding patch v3.

    Lukas

    \
     
     \ /
      Last update: 2022-09-09 13:14    [W:4.001 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site