lkml.org 
[lkml]   [2022]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v1 1/1] serial: 8250_dma: Convert to use uart_xmit_advance()
On Fri, 9 Sep 2022, Andy Shevchenko wrote:

> uart_xmit_advance() provides a common way on how to advance
> the Tx queue. Use it for the sake of unification and robustness.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/tty/serial/8250/8250_dma.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_dma.c b/drivers/tty/serial/8250/8250_dma.c
> index d99020fd3427..b85c82616e8c 100644
> --- a/drivers/tty/serial/8250/8250_dma.c
> +++ b/drivers/tty/serial/8250/8250_dma.c
> @@ -26,9 +26,7 @@ static void __dma_tx_complete(void *param)
>
> dma->tx_running = 0;
>
> - xmit->tail += dma->tx_size;
> - xmit->tail &= UART_XMIT_SIZE - 1;
> - p->port.icount.tx += dma->tx_size;
> + uart_xmit_advance(&p->port, dma->tx_size);
>
> if (uart_circ_chars_pending(xmit) < WAKEUP_CHARS)
> uart_write_wakeup(&p->port);

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

Please note though that I already have patches for almost all these but
I've not just submitted the remaining ones yet.


--
i.
\
 
 \ /
  Last update: 2022-09-09 11:17    [W:0.117 / U:1.904 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site