lkml.org 
[lkml]   [2022]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/8] termios: uninline conversion helpers
On Thu, Sep 01, 2022 at 06:03:04PM +0100, Al Viro wrote:
> On Tue, Aug 30, 2022 at 02:26:16PM +0200, Greg Kroah-Hartman wrote:
> > On Sun, Aug 21, 2022 at 02:02:34AM +0100, Al Viro wrote:
> > > default go into drivers/tty/tty_ioctl.c, unusual - into
> > > arch/*/kernel/termios.c (only alpha and sparc have those).
> > >
> > > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> > > ---
> > > arch/alpha/include/asm/termios.h | 77 ++--------------
> > > arch/alpha/kernel/Makefile | 2 +-
> > > arch/alpha/kernel/termios.c | 57 ++++++++++++
> > > arch/ia64/include/asm/termios.h | 41 ++-------
> > > arch/mips/include/asm/termios.h | 84 ++----------------
> > > arch/parisc/include/asm/termios.h | 41 ++-------
> > > arch/sparc/include/asm/termios.h | 136 ++---------------------------
> > > arch/sparc/kernel/Makefile | 4 +-
> > > arch/sparc/kernel/termios.c | 115 ++++++++++++++++++++++++
> > > drivers/tty/tty_ioctl.c | 74 ++++++++++++++++
> > > include/asm-generic/termios-base.h | 69 ++-------------
> > > include/asm-generic/termios.h | 42 ++-------
> > > 12 files changed, 294 insertions(+), 448 deletions(-)
> > > create mode 100644 arch/alpha/kernel/termios.c
> > > create mode 100644 arch/sparc/kernel/termios.c
> >
> > The build blows up on me with this commit added to my tty-testing tree:
>
> My apologies - reordering damage. inlines in include/asm-generic/termios.h
> should've been removed in this commit, not in the next one.
>
> Anyway, fixed branch rebased on top of your #tty-next; see
> vfs.git #work.termios2. Individual patches in followups...

Thanks, much better, I've applied these and let's see if 0-day has any
problems with them...

greg k-h

\
 
 \ /
  Last update: 2022-09-09 10:47    [W:0.094 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site