lkml.org 
[lkml]   [2022]   [Sep]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/2] dt-bindings: arm: Add i.MX8M Mini Gateworks GW7904 board
From
On 08/09/2022 23:44, Tim Harvey wrote:
> On Thu, Sep 8, 2022 at 2:19 PM Rob Herring <robh@kernel.org> wrote:
>>
>> On Fri, Sep 02, 2022 at 04:04:59PM -0700, Tim Harvey wrote:
>>> Add DT compatible string for i.MX8M Mini based Gateworks GW7904 board.
>>>
>>> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
>>> Cc: Rob Herring <robh+dt@kernel.org>
>>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>>> Cc: Shawn Guo <shawnguo@kernel.org>
>>> Cc: Sascha Hauer <s.hauer@pengutronix.de>
>>> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
>>> Cc: Fabio Estevam <festevam@gmail.com>
>>> Cc: NXP Linux Team <linux-imx@nxp.com>
>>> ---
>>> Documentation/devicetree/bindings/arm/fsl.yaml | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
>>> index 7431579ab0e8..ce89fac1898e 100644
>>> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
>>> @@ -831,6 +831,7 @@ properties:
>>> - gw,imx8mm-gw7901 # i.MX8MM Gateworks Board
>>> - gw,imx8mm-gw7902 # i.MX8MM Gateworks Board
>>> - gw,imx8mm-gw7903 # i.MX8MM Gateworks Board
>>> + - gateworks,imx8mm-gw7904 # i.MX8MM Gateworks Board
>>
>> A useful comment would be ones that distuiguish these boards. It's
>> obvious from the compatible it's a i.MX8MM board from Gateworks.
>
> But isn't it clear that you need to go to the device-tree itself to
> understand the details?
>
> As far as basic features go sometimes there is very little difference
> in these board models. It would be a struggle to list all the board
> details (which I do in the dts commit) in a way that doesn't take up
> too much space in fsl.yaml.
>

But then the comment you added is useless. So either add useful comment
or no comment. :)


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-09-09 10:03    [W:0.058 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site