Messages in this thread | | | From | <> | Subject | Re: [PATCH v2 06/13] dt-bindings: serial: atmel,at91-usart: Add SAM9260 compatibles to SAM9x60 | Date | Thu, 8 Sep 2022 15:15:44 +0000 |
| |
On 08.09.2022 15:30, Krzysztof Kozlowski wrote: > On 06/09/2022 15:55, Sergiu Moga wrote: >> Add the AT91SAM9260 serial compatibles to the list of SAM9X60 compatibles >> in order to highlight the incremental characteristics of the SAM9X60 >> serial IP. >> >> Signed-off-by: Sergiu Moga <sergiu.moga@microchip.com> >> --- >> >> >> v1 -> v2: >> - Nothing, this patch was not here before >> >> >> Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml >> index b25535b7a4d2..4d80006963c7 100644 >> --- a/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml >> +++ b/Documentation/devicetree/bindings/serial/atmel,at91-usart.yaml >> @@ -26,6 +26,8 @@ properties: >> - items: >> - const: microchip,sam9x60-dbgu >> - const: microchip,sam9x60-usart >> + - const: atmel,at91sam9260-dbgu >> + - const: atmel,at91sam9260-usart > > This is weird. You say in commit msg to "highlight the incremental > characteristics" but you basically change here existing compatibles.
Does "show that they are incremental IP's" sound better then?
> This is not enum, but a list. >
What do you mean by this? I know it is a list, I specified so in the commit message.
> > Best regards, > Krzysztof
Regards, Sergiu
| |