lkml.org 
[lkml]   [2022]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 4/4] dt-bindings: net: snps,dwmac: Update interrupt-names
From
On 07/09/2022 22:49, Bhupesh Sharma wrote:
> As commit fc191af1bb0d ("net: stmmac: platform: Fix misleading
> interrupt error msg") noted, not every stmmac based platform
> makes use of the 'eth_wake_irq' or 'eth_lpi' interrupts.
>
> So, update the 'interrupt-names' inside 'snps,dwmac' YAML
> bindings to reflect the same.
>
> Cc: Bjorn Andersson <andersson@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Vinod Koul <vkoul@kernel.org>
> Cc: David Miller <davem@davemloft.net>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
> Documentation/devicetree/bindings/net/snps,dwmac.yaml | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index f89ca308d55f..4d7fe4ee3d87 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -105,10 +105,12 @@ properties:
>
> interrupt-names:
> minItems: 1
> - items:
> - - const: macirq
> - - const: eth_wake_irq
> - - const: eth_lpi
> + maxItems: 3
> + contains:
> + enum:
> + - macirq
> + - eth_wake_irq
> + - eth_lpi
>

This gives quite a flexibility, e.g. missing macirq. Instead should be
probably a list with enums:
items:
- const: macirq
- enum: [eth_wake_irq, eth_lpi]
- enum: [eth_wake_irq, eth_lpi]


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-09-08 16:45    [W:0.150 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site