Messages in this thread | | | Date | Thu, 8 Sep 2022 13:04:55 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 8/8] efi/dev-path-parser: Refactor _UID handling to use acpi_dev_uid_to_integer() |
| |
On Thu, Sep 08, 2022 at 11:29:22AM +0200, Hans de Goede wrote: > On 9/7/22 18:46, Andy Shevchenko wrote:
...
> > + long ret; > > "long ret" should be "int ret" here since that is what acpi_dev_uid_to_integer() > returns.
I put it long since the efi_get_device_by_path() uses long ret (for the sake of consistency with the existing code), but I have no objections to move it to int.
-- With Best Regards, Andy Shevchenko
| |