lkml.org 
[lkml]   [2022]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/15] cxl/core: Remove duplicate declaration of devm_cxl_iomap_block()
Robert Richter wrote:
> On 07.09.22 22:44:01, Dan Williams wrote:
> > Robert Richter wrote:
> > > The function devm_cxl_iomap_block() is only used in the core
> > > code. There are two declarations in header files of it, in
> > > drivers/cxl/core/core.h and drivers/cxl/cxl.h. Remove its unused
> > > declaration in drivers/cxl/cxl.h.
> > >
> > > Signed-off-by: Robert Richter <rrichter@amd.com>
> >
> > Looks good,
> >
> > Reviewed-by: Dan Williams <dan.j.williams@intel.com>
>
> Note there was a 0day build error. So I will add the inclusion of
> "core.h" to core/regs.c to this patch. I hope that is ok.

Yes, for my Reviewed-by: small fixups that don't touch the core theme of
the patch are ok.

\
 
 \ /
  Last update: 2022-09-08 21:48    [W:0.102 / U:1.444 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site