Messages in this thread | | | From | <> | Subject | RE: [PATCH v2 net-next] net: phy: micrel: Adding SQI support for lan8814 phy | Date | Wed, 7 Sep 2022 09:24:06 +0000 |
| |
Hi Michael,
> -----Original Message----- > From: Michael Walle <michael@walle.cc> > Sent: Wednesday, September 7, 2022 2:38 PM > To: Divya Koppera - I30481 <Divya.Koppera@microchip.com> > Cc: andrew@lunn.ch; UNGLinuxDriver <UNGLinuxDriver@microchip.com>; > davem@davemloft.net; edumazet@google.com; hkallweit1@gmail.com; > kuba@kernel.org; linux-kernel@vger.kernel.org; linux@armlinux.org.uk; > netdev@vger.kernel.org; pabeni@redhat.com; Oleksij Rempel > <o.rempel@pengutronix.de>; Michael Walle <michael@walle.cc> > Subject: Re: [PATCH v2 net-next] net: phy: micrel: Adding SQI support for > lan8814 phy > > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > > On Mon, Sep 05, 2022 at 03:47:30PM +0530, Divya Koppera wrote: > >> Supports SQI(Signal Quality Index) for lan8814 phy, where it has SQI > >> index of 0-7 values and this indicator can be used for cable > >> integrity diagnostic and investigating other noise sources. It is not > >> supported for 10Mbps speed > >> > >> Signed-off-by: Divya Koppera <Divya.Koppera@microchip.com> > >> --- > >> v1 -> v2 > >> - Given SQI support for all pairs of wires in 1000/100 base-T phy's > >> uAPI may run through all instances in future. At present returning > >> only first instance as uAPI supports for only 1 pair. > >> - SQI is not supported for 10Mbps speed, handled accordingly. > > > > I would prefer you solve the problem of returning all pairs. > > > > I'm not sure how useful the current implementation is, especially at > > 100Mbps, where pair 0 could actually be the transmit pair. Does it > > give a sensible value in that case? > > It is good practice to CC the patches to the ones who gave feedback on the > previous versions. Not everyone is subscribed to all the high traffic > mailinglist. >
Sorry I missed adding you.
> Thanks, > -michael
| |