lkml.org 
[lkml]   [2022]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] driver: of: overlay: demote message to warning
On Wed, Sep 07, 2022 at 06:54:02PM -0500, Frank Rowand wrote:
> On 9/7/22 18:07, Daniel Walker wrote:
> > This warning message shows by default on the vast majority of overlays
> > applied. Despite the text identifying this as a warning it is marked
> > with the loglevel for error. At Cisco we filter the loglevels to only
> > show error messages. We end up seeing this message but it's not really
> > an error.
> >
> > For this reason it makes sense to demote the message to the warning
> > loglevel.
> >
> > Cc: xe-linux-external@cisco.com
> > Signed-off-by: Daniel Walker <danielwa@cisco.com>
> > ---
> > drivers/of/overlay.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
> > index bd8ff4df723d..4ae276ed9a65 100644
> > --- a/drivers/of/overlay.c
> > +++ b/drivers/of/overlay.c
> > @@ -358,7 +358,7 @@ static int add_changeset_property(struct overlay_changeset *ovcs,
> > }
> >
> > if (!of_node_check_flag(target->np, OF_OVERLAY))
> > - pr_err("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
> > + pr_warn("WARNING: memory leak will occur if overlay removed, property: %pOF/%s\n",
> > target->np, new_prop->name);
> >
> > if (ret) {
>
> NACK
>
> This is showing a real problem with the overlay.

What's the real problem ?

Daniel

\
 
 \ /
  Last update: 2022-09-08 02:36    [W:0.091 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site