lkml.org 
[lkml]   [2022]   [Sep]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v4 02/21] dt-bindings: hwmon: (mr75203) fix "intel, vm-map" property to be optional
Date
From
On 9/6/2022 7:53 PM, Guenter Roeck wrote:
> On Tue, Sep 06, 2022 at 08:33:37AM +0000, Eliav Farber wrote:
>> Change "intel,vm-map" property to be optional instead of required.
>>
>> The driver implementation indicates it is not mandatory to have
>> "intel,vm-map" in the device tree:
>>  - probe doesn't fail in case it is absent.
>>  - explicit comment in code - "Incase intel,vm-map property is not
>>    defined, we assume incremental channel numbers".
>>
>> Fixes: 748022ef093f ("hwmon: Add DT bindings schema for PVT controller")
>> Signed-off-by: Eliav Farber <farbere@amazon.com>
>> ---
>> V3 -> V2:
>> - Change this patch to be first in the series.
>> - Add explanation why "intel,vm-map" is not required.
>>
>
> I don't see how this change warrants dropping Rob's Acked-by tag.
> Am I missing something ?

My apology. I wasn’t aware I had to keep the Acked-by tag.
I'll add it in v5.

--
Regards, Eliav


\
 
 \ /
  Last update: 2022-09-07 08:29    [W:0.082 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site