Messages in this thread | | | Date | Wed, 7 Sep 2022 20:00:42 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 2/9] pwm: lpss: Move exported symbols to PWM_LPSS namespace |
| |
On Wed, Sep 07, 2022 at 05:21:53PM +0300, Andy Shevchenko wrote: > On Wed, Sep 07, 2022 at 11:11:44AM +0200, Uwe Kleine-König wrote: > > On Tue, Sep 06, 2022 at 10:57:28PM +0300, Andy Shevchenko wrote:
...
> > > -EXPORT_SYMBOL_GPL(pwm_lpss_probe); > > > +EXPORT_SYMBOL_NS_GPL(pwm_lpss_probe, PWM_LPSS); > > > > There is something possible with more magic: > > #define DEFAULT_SYMBOL_NAMESPACE PWM_LPSS > > > > which you only need once in pwm-lpss.c and then all exports use that > > namespace. (And if you pick up my suggestion for patch 1 you also > > benefit from that.) > > For a single export (even for a few of them) it's an overkill.
Ah, you adding there 4 more. But still I think it's an overkill. It's so small driver that duplicating namespace in each of the exported symbols is not an issue, is it?
-- With Best Regards, Andy Shevchenko
| |