lkml.org 
[lkml]   [2022]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 072/155] misc: fastrpc: fix memory corruption on probe
    Date
    From: Johan Hovold <johan+linaro@kernel.org>

    commit 9baa1415d9abdd1e08362ea2dcfadfacee8690b5 upstream.

    Add the missing sanity check on the probed-session count to avoid
    corrupting memory beyond the fixed-size slab-allocated session array
    when there are more than FASTRPC_MAX_SESSIONS sessions defined in the
    devicetree.

    Fixes: f6f9279f2bf0 ("misc: fastrpc: Add Qualcomm fastrpc basic driver model")
    Cc: stable@vger.kernel.org # 5.1
    Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
    Link: https://lore.kernel.org/r/20220829080531.29681-2-johan+linaro@kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/misc/fastrpc.c | 5 +++++
    1 file changed, 5 insertions(+)

    --- a/drivers/misc/fastrpc.c
    +++ b/drivers/misc/fastrpc.c
    @@ -1943,6 +1943,11 @@ static int fastrpc_cb_probe(struct platf
    of_property_read_u32(dev->of_node, "qcom,nsessions", &sessions);

    spin_lock_irqsave(&cctx->lock, flags);
    + if (cctx->sesscount >= FASTRPC_MAX_SESSIONS) {
    + dev_err(&pdev->dev, "too many sessions\n");
    + spin_unlock_irqrestore(&cctx->lock, flags);
    + return -ENOSPC;
    + }
    sess = &cctx->session[cctx->sesscount];
    sess->used = false;
    sess->valid = true;

    \
     
     \ /
      Last update: 2022-09-06 16:18    [W:4.871 / U:0.416 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site