lkml.org 
[lkml]   [2022]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 066/155] tty: serial: lpuart: disable flow control while waiting for the transmit engine to complete
    Date
    From: Sherry Sun <sherry.sun@nxp.com>

    commit d5a2e0834364377a5d5a2fff1890a0b3f0bafd1f upstream.

    When the user initializes the uart port, and waits for the transmit
    engine to complete in lpuart32_set_termios(), if the UART TX fifo has
    dirty data and the UARTMODIR enable the flow control, the TX fifo may
    never be empty. So here we should disable the flow control first to make
    sure the transmit engin can complete.

    Fixes: 380c966c093e ("tty: serial: fsl_lpuart: add 32-bit register interface support")
    Cc: stable <stable@kernel.org>
    Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
    Link: https://lore.kernel.org/r/20220821101527.10066-1-sherry.sun@nxp.com
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/tty/serial/fsl_lpuart.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/tty/serial/fsl_lpuart.c
    +++ b/drivers/tty/serial/fsl_lpuart.c
    @@ -2182,6 +2182,7 @@ lpuart32_set_termios(struct uart_port *p
    uart_update_timeout(port, termios->c_cflag, baud);

    /* wait transmit engin complete */
    + lpuart32_write(&sport->port, 0, UARTMODIR);
    lpuart32_wait_bit_set(&sport->port, UARTSTAT, UARTSTAT_TC);

    /* disable transmit and receive */

    \
     
     \ /
      Last update: 2022-09-06 16:18    [W:4.184 / U:0.044 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site