lkml.org 
[lkml]   [2022]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.19 033/155] net: sparx5: fix handling uneven length packets in manual extraction
    Date
    From: Casper Andersson <casper.casan@gmail.com>

    [ Upstream commit 7498a457ecf7ff2c4d379360aa8f24566bb1543e ]

    Packets that are not of length divisible by 4 (e.g. 77, 78, 79) would
    have the checksum included up to next multiple of 4 (a 77 bytes packet
    would have 3 bytes of ethernet checksum included). The check for the
    value expects it in host (Little) endian.

    Fixes: f3cad2611a77 ("net: sparx5: add hostmode with phylink support")
    Signed-off-by: Casper Andersson <casper.casan@gmail.com>
    Reviewed-by: Steen Hegelund <Steen.Hegelund@microchip.com>
    Link: https://lore.kernel.org/r/20220825084955.684637-1-casper.casan@gmail.com
    Signed-off-by: Jakub Kicinski <kuba@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/microchip/sparx5/sparx5_packet.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c b/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c
    index 304f84aadc36b..21844beba72df 100644
    --- a/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c
    +++ b/drivers/net/ethernet/microchip/sparx5/sparx5_packet.c
    @@ -113,6 +113,8 @@ static void sparx5_xtr_grp(struct sparx5 *sparx5, u8 grp, bool byte_swap)
    /* This assumes STATUS_WORD_POS == 1, Status
    * just after last data
    */
    + if (!byte_swap)
    + val = ntohl((__force __be32)val);
    byte_cnt -= (4 - XTR_VALID_BYTES(val));
    eof_flag = true;
    break;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-09-06 16:06    [W:2.523 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site