Messages in this thread | | | Date | Tue, 6 Sep 2022 12:42:32 +0100 | Subject | Re: [PATCH] drm/amdgpu: cleanup coding style in amdgpu_drv.c | From | Robin Murphy <> |
| |
On 2022-09-04 20:15, Jingyu Wang wrote: [...] > @@ -565,8 +566,8 @@ module_param_named(timeout_period, amdgpu_watchdog_timer.period, uint, 0644); > */ > #ifdef CONFIG_DRM_AMDGPU_SI > > -#if defined(CONFIG_DRM_RADEON) || defined(CONFIG_DRM_RADEON_MODULE) > -int amdgpu_si_support = 0; > +#if IS_ENABLED(CONFIG_DRM_RADEON) || defined(CONFIG_DRM_RADEON_MODULE)
Hint: read the checkpatch warning again more closely, and consider what IS_ENABLED() does and therefore why this is still not quite right.
Robin.
> +int amdgpu_si_support; > MODULE_PARM_DESC(si_support, "SI support (1 = enabled, 0 = disabled (default))"); > #else > int amdgpu_si_support = 1;
| |