Messages in this thread | | | Date | Tue, 6 Sep 2022 12:53:44 +0200 | Subject | Re: [PATCH v10 0/6] Raspberry Pi Sense HAT driver | From | Matthias Brugger <> |
| |
On 06/09/2022 04:21, Bagas Sanjaya wrote: > On Tue, Aug 23, 2022 at 01:41:53PM -0400, Charles Mirabile wrote: >> This patch series adds a set of drivers for operating the Sense HAT >> peripheral device. This board is an add on for the Raspberry Pi that is >> designed to connect using the GPIO connector and communicate via I2C. >> > > Better say "Add a set of drivers for Sense HAT peripheral add-on device > for Raspberry Pi. The device is connected using GPIO connector and > communicate via I2C". >
The cover letter won't be part of the git log, so as long as it's understandable it's OK. It makes no sense to review the wording...
Regards, Matthias
>> This is a refactor of the work of Serge Schneider, the author of a >> version of this driver that is currently in the Raspberry Pi downstream >> kernel. We modified his code to make it suitable for upstream Linux. >> > > s/We modified his code/The driver code is modified/ > > Also, I see that description of individual patches is written in > descriptive mood. However, it is preferable to write in imperative > instead (see "Describe your changes" in > Documentation/process/submitting-patches.rst). The specific suggested > wordings are in reply to each patch. > > Thanks. >
| |