lkml.org 
[lkml]   [2022]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] of: irq: Report individual failures in of_irq_init()
Date
From: Alexander Sverdlin <alexander.sverdlin@nokia.com>

Rewrite pr_debug() as pr_err() to faciliate debugging.

This change was inspired by a long lasting debugging of the
octeon_irq_init_ciu() which fails completely silently and leaves the
interrupt controller half-way configured which in turn had very non-obvious
effects.

Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
---
drivers/of/irq.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index d22f605..45e4392 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -586,12 +586,12 @@ void __init of_irq_init(const struct of_device_id *matches)

of_node_set_flag(desc->dev, OF_POPULATED);

- pr_debug("of_irq_init: init %pOF (%p), parent %p\n",
- desc->dev,
- desc->dev, desc->interrupt_parent);
ret = desc->irq_init_cb(desc->dev,
desc->interrupt_parent);
if (ret) {
+ pr_err("%s: Failed to init %pOF (%p), parent %p\n",
+ __func__, desc->dev, desc->dev,
+ desc->interrupt_parent);
of_node_clear_flag(desc->dev, OF_POPULATED);
kfree(desc);
continue;
--
2.10.2
\
 
 \ /
  Last update: 2022-09-06 12:00    [W:0.074 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site