Messages in this thread | | | From | Zixuan Tan <> | Date | Tue, 6 Sep 2022 17:40:24 +0800 | Subject | Re: [PATCH] perf/genelf: Switch deprecated openssl MD5_* functions to new EVP API |
| |
Hi Arnaldo, are there any updates?
Thanks, - Zixuan
On Sat, Aug 27, 2022 at 2:32 AM Namhyung Kim <namhyung@kernel.org> wrote: > > Hello, > > On Fri, Aug 26, 2022 at 10:22 AM Zixuan Tan <tanzixuan.me@gmail.com> wrote: > > > > On Fri, Aug 26, 2022 at 4:17 AM Arnaldo Carvalho de Melo > > <arnaldo.melo@gmail.com> wrote: > > > > > > Em Fri, Aug 26, 2022 at 01:00:58AM +0800, Zixuan Tan escreveu: > > > > Switch to the flavored EVP API like in test-libcrypto.c, and remove the > > > > bad gcc #pragma. > > > > > > > > Inspired-By: 5b245985a6de ("tools build: Switch to new openssl API for > > > > test-libcrypto") > > > > > > How did you test the end result? Can you please describe step by step? > > > > > > Also please consider adding a 'perf test' entry to make sure this > > > doesn't regress. > > > > Sorry but I don't get what you mean, what results do I need to test? > > > > These EVP_* APIs are just replacements for the deprecated MD5_* APIs in > > openssl v3 [1][2]. With the same input, they produce the same MD5 digest. > > > > And this patch just does the migration work for the upgrade and does not > > change the logic of the code. so...what should I test? > > Yeah, I understand that this merely changes the MD5 APIs. > While it's good to have a test case for the genelf code, I don't think > it belongs to this patch. So, > > Acked-by: Namhyung Kim <namhyung@kernel.org> > > > > > > Links: > > [1] https://www.openssl.org/docs/man3.0/man3/MD5.html > > [2] https://stackoverflow.com/questions/69806220/advice-needed-for-migration-of-low-level-openssl-api-to-high-level-openssl-apis
| |