Messages in this thread | | | From | Sandipan Patra <> | Subject | RE: [PATCH 1/2] arm64: tegra: Add PWM controllers on Tegra234 | Date | Tue, 6 Sep 2022 08:47:50 +0000 |
| |
Hi Krzysztof,
> > + pwm2: pwm@3290000 { > > + compatible = "nvidia,tegra194-pwm", > > + "nvidia,tegra186-pwm"; > > This does not match bindings. Either DTS or bindings need to be fixed.
Thanks for reviewing the patches.
Tegra234 uses same compatible as Tegra194. And also we can clear "nvidia,tegra186-pwm" from the Tegra234 pwm compatible list. I will update binding doc and push new patch.
Thanks & Regards, Sandipan
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: Tuesday, August 30, 2022 3:20 PM > To: Sandipan Patra <spatra@nvidia.com>; thierry.reding@gmail.com; > Jonathan Hunter <jonathanh@nvidia.com>; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; devicetree@vger.kernel.org; linux- > tegra@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: Bibek Basu <bbasu@nvidia.com>; Krishna Yarlagadda > <kyarlagadda@nvidia.com> > Subject: Re: [PATCH 1/2] arm64: tegra: Add PWM controllers on Tegra234 > > External email: Use caution opening links or attachments > > > On 29/08/2022 14:44, Sandipan Patra wrote: > > Tegra234 has eight single-channel PWM controllers, one of them in the > > AON block. > > > > Signed-off-by: Sandipan Patra <spatra@nvidia.com> > > --- > > arch/arm64/boot/dts/nvidia/tegra234.dtsi | 84 > > ++++++++++++++++++++++++ > > 1 file changed, 84 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/nvidia/tegra234.dtsi > > b/arch/arm64/boot/dts/nvidia/tegra234.dtsi > > index 81a0f599685f..c2dc651f0842 100644 > > --- a/arch/arm64/boot/dts/nvidia/tegra234.dtsi > > +++ b/arch/arm64/boot/dts/nvidia/tegra234.dtsi > > @@ -840,6 +840,90 @@ > > #pwm-cells = <2>; > > }; > > > > + pwm2: pwm@3290000 { > > + compatible = "nvidia,tegra194-pwm", > > + "nvidia,tegra186-pwm"; > > This does not match bindings. Either DTS or bindings need to be fixed. > > Best regards, > Krzysztof
| |