Messages in this thread | | | Date | Tue, 6 Sep 2022 22:03:46 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v5 1/6] tracing: Allow multiple hitcount values in histograms |
| |
On Sun, 4 Sep 2022 13:12:20 +0900 "Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> From: Tom Zanussi <zanussi@kernel.org> > > The hitcount is treated specially in the histograms - since it's > always expected to be there regardless of whether the user specified > anything or not, it's always added as the first histogram value. > > Currently the code doesn't allow it to be added more than once as a > value, which is inconsistent with all the other possible values. It > would seem to be a pointless thing to want to do, but other features > being added such as percent and graph modifiers don't work properly > with the current hitcount restrictions. > > Fix this by allowing multiple hitcounts to be added. > > Signed-off-by: Tom Zanussi <zanussi@kernel.org>
Hi Masami,
When posting patches from other people, you still need to add your Signed-off-by, as that denotes the people who processed the patch before it made it into git.
-- Steve
| |