Messages in this thread | | | From | Sudip Mukherjee <> | Date | Tue, 6 Sep 2022 22:07:53 +0100 | Subject | Re: build failure of next-20220906 due to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers.") |
| |
Hi Greg,
On Tue, Sep 6, 2022 at 6:15 PM Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > > On Tue, Sep 06, 2022 at 03:23:22PM +0100, Sudip Mukherjee (Codethink) wrote: > > Hi All, > > > > The builds of riscv, s390, csky, alpha and loongarch allmodconfig have > > failed to build next-20220906 with the error: > > > > > > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:311:12: error: 'pci1xxxx_gpio_resume' defined but not used [-Werror=unused-function] > > 311 | static int pci1xxxx_gpio_resume(struct device *dev) > > | ^~~~~~~~~~~~~~~~~~~~ > > drivers/misc/mchp_pci1xxxx/mchp_pci1xxxx_gpio.c:295:12: error: 'pci1xxxx_gpio_suspend' defined but not used [-Werror=unused-function] > > 295 | static int pci1xxxx_gpio_suspend(struct device *dev) > > | ^~~~~~~~~~~~~~~~~~~~~ > > > > > > git bisect pointed to 4ec7ac90ff39 ("misc: microchip: pci1xxxx: Add power management functions - suspend & resume handlers."). > > > > I will be happy to test any patch or provide any extra log if needed. > > Hopefully this commit will fix this: > https://lore.kernel.org/r/20220906124951.696776-1-kumaravel.thiagarajan@microchip.com
No, it didn't. :(
Looking at other drivers which uses SIMPLE_DEV_PM_OPS, I think pci1xxxx_gpio_suspend() and pci1xxxx_gpio_resume() needs to be under "#ifdef CONFIG_PM_SLEEP".
-- Regards Sudip
| |