| Date | Tue, 6 Sep 2022 23:07:17 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v1 2/5] fpga: dfl: Move the DFH definitions |
| |
On Tue, Sep 06, 2022 at 12:04:23PM -0700, matthew.gerlach@linux.intel.com wrote: > From: Basheer Ahmed Muddebihal <basheer.ahmed.muddebihal@linux.intel.com> > > Moving the DFH register offset and register definitions from > drivers/fpga/dfl.h to include/linux/dfl.h. These definitions
Single space?
> need to be accessed by dfl drivers that are outside of > drivers/fpga.
...
> +#define DFH 0x0 > +#define GUID_L 0x8 > +#define GUID_H 0x10 > +#define NEXT_AFU 0x18
While at it, you may make them same width, like "0x08".
-- With Best Regards, Andy Shevchenko
|