Messages in this thread | | | From | Jernej Škrabec <> | Subject | Re: [RESEND] clocksource: sun4i: add definition of clear interrupt | Date | Tue, 06 Sep 2022 21:54:15 +0200 |
| |
Dne torek, 06. september 2022 ob 07:20:56 CEST je Victor Hassan napisal(a): > To prevent misunderstanding, use TIMER_IRQ_CLEAR instead of TIMER_IRQ_EN > in function sun4i_timer_clear_interrupt. > > Signed-off-by: Victor Hassan <victor@allwinnertech.com>
Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Best regards, Jernej
> --- > drivers/clocksource/timer-sun4i.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/clocksource/timer-sun4i.c > b/drivers/clocksource/timer-sun4i.c index 94dc6e42e983..e5a70aa1deb4 100644 > --- a/drivers/clocksource/timer-sun4i.c > +++ b/drivers/clocksource/timer-sun4i.c > @@ -26,6 +26,7 @@ > #define TIMER_IRQ_EN_REG 0x00 > #define TIMER_IRQ_EN(val) BIT(val) > #define TIMER_IRQ_ST_REG 0x04 > +#define TIMER_IRQ_CLEAR(val) BIT(val) > #define TIMER_CTL_REG(val) (0x10 * val + 0x10) > #define TIMER_CTL_ENABLE BIT(0) > #define TIMER_CTL_RELOAD BIT(1) > @@ -123,7 +124,7 @@ static int sun4i_clkevt_next_event(unsigned long evt, > > static void sun4i_timer_clear_interrupt(void __iomem *base) > { > - writel(TIMER_IRQ_EN(0), base + TIMER_IRQ_ST_REG); > + writel(TIMER_IRQ_CLEAR(0), base + TIMER_IRQ_ST_REG); > } > > static irqreturn_t sun4i_timer_interrupt(int irq, void *dev_id) > -- > 2.29.0
| |