Messages in this thread | | | From | Linus Walleij <> | Date | Tue, 6 Sep 2022 20:58:40 +0200 | Subject | Re: [PATCH v2] mfd: stmpe: switch to using gpiod API |
| |
On Tue, Sep 6, 2022 at 8:35 PM Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote:
> This patch switches the driver away from legacy gpio/of_gpio API to > gpiod API, and removes use of of_get_named_gpio_flags() which I want to > make private to gpiolib. > > We also need to patch relevant DTS files, as the original code relied on > the fact that of_get_named_gpio_flags() would fetch any data encoded in > GPIO flags, even if it does not reflect valid flags for a GPIO. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> --- > > v1->v2: > - add DTS changes, as noticed by Francesco Dolcini. > > I guess we could do a dance of changing stmpe to check the flags coming > from DTS and try to distinguish IRQ flags from proper GPIO flags, then > have a separate patch changing DTSes, and finally a 2nd patch to stmpe > to use GPIOD API, but I am hoping we could apply this in one go...
It's a mess, let's just apply it and forget about it. It's one of those trees falling in the forest and noone is there to hear it fall-type of things.
Yours, Linus Walleij
| |