lkml.org 
[lkml]   [2022]   [Sep]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] KVM/VMX: Do not declare vmread_error asmlinkage
Date
On Thursday, September 1, 2022 11:37 PM, Sean Christopherson wrote:
> > > And vmread_error() isn't the only case where asmlinkage appears to be a
> burden, e.g.
> > > schedule_tail_wrapper() => schedule_tail() seems to exist purely to
> > > deal with the side affect of asmlinkage generating -regparm=0 on 32-bit
> kernels.
> >
> > schedule_tail is external to the x86 arch directory, and for some
> > reason marked asmlinkage. So, the call from asm must follow asmlinkage
> > ABI.
>
> Ahhh, it's a common helper that's called from assembly on other architectures.
> That makes sense.

I still doubt the necessity. The compilation is architecture specific, and we don't
build one architecture-agnostic kernel binary to run on different architectures,
right?

Thanks,
Wei

\
 
 \ /
  Last update: 2022-09-06 09:29    [W:0.178 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site