Messages in this thread | | | Date | Tue, 6 Sep 2022 09:46:43 -0700 | Subject | Re: [PATCH v5 07/12] x86/cpu/keylocker: Load an internal wrapping key at boot-time | From | "Chang S. Bae" <> |
| |
On 9/6/2022 9:22 AM, Evan Green wrote: > On Wed, Aug 31, 2022 at 4:16 PM Chang S. Bae <chang.seok.bae@intel.com> wrote: > > But this still doesn't explain this crash, since in this case we're > still on our way down and haven't even done the shutdown yet. We can > see the "PM: hibernation: Image created (1536412 pages copied)" log > line just before the keylocker read failure. So then it seems > something's not working with the pre-hibernate CPU hotplug path?
No, that backup crash message came from the boot-CPU's wakeup path: __restore_processor_state()->restore_keylocker().
If the issue is repeatable, then I suspect that's something to do with the specific platform implementation. I don't have any detail yet on the customized systems. Let me check with some Chrome HW folks.
> How were you exercising the CPU onlining in this case? Boot, cpu > hotplug, or hibernate?
Hibernate.
Thanks, Chang
| |