Messages in this thread | | | Date | Tue, 06 Sep 2022 08:09:14 +0100 | From | Marc Zyngier <> | Subject | Re: [PATCH] PCI: apple: do not leak reset GPIO on unbind/unload/error |
| |
On Tue, 06 Sep 2022 03:15:23 +0100, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > > The driver allocates reset GPIO in apple_pcie_setup_port() but neither > releases the resource, nor uses devm API to have it released > automatically. > > Let's fix this by switching to devm API. While at it let's use generic > devm_fwnode_gpiod_get() instead of OF-specific gpiod_get_from_of_node() > - this will allow us top stop exporting the latter down the road. > > Fixes: 1e33888fbe44 ("PCI: apple: Add initial hardware bring-up") > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Marc Zyngier <maz@kernel.org>
M.
-- Without deviation from the norm, progress is not possible.
| |