Messages in this thread Patch in this message | | | From | Cristian Marussi <> | Subject | [PATCH v2 2/3] powercap: arm_scmi: Fix signedness bug in probe | Date | Tue, 6 Sep 2022 15:23:36 +0100 |
| |
From: Dan Carpenter <dan.carpenter@oracle.com>
The "pr->num_zones" variable is an unsigned int so it can't be less than zero.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/powercap/arm_scmi_powercap.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/powercap/arm_scmi_powercap.c b/drivers/powercap/arm_scmi_powercap.c index a91438867f8c..76200c004cad 100644 --- a/drivers/powercap/arm_scmi_powercap.c +++ b/drivers/powercap/arm_scmi_powercap.c @@ -389,11 +389,12 @@ static int scmi_powercap_probe(struct scmi_device *sdev) if (!pr) return -ENOMEM; - pr->num_zones = powercap_ops->num_domains_get(ph); - if (pr->num_zones < 0) { + ret = powercap_ops->num_domains_get(ph); + if (ret < 0) { dev_err(dev, "number of powercap domains not found\n"); - return pr->num_zones; + return ret; } + pr->num_zones = ret; pr->spzones = devm_kcalloc(dev, pr->num_zones, sizeof(*pr->spzones), GFP_KERNEL); -- 2.32.0
| |