Messages in this thread | | | Date | Tue, 6 Sep 2022 17:28:37 +0300 | From | Andy Shevchenko <> | Subject | Re: [PATCH v2 5/5] gpio: pca953x: Add support for PCAL6534 |
| |
On Tue, Sep 06, 2022 at 03:01:51PM +0100, Martyn Welch wrote: > On Tue, 2022-09-06 at 15:24 +0300, Andy Shevchenko wrote: > > On Tue, Sep 06, 2022 at 09:28:19AM +0100, Martyn Welch wrote:
...
> > > + u8 (*recalc_addr)(struct pca953x_chip *chip, int reg , int > > > off); > > > + bool (*check_reg)(struct pca953x_chip *chip, unsigned int > > > reg, > > > + u32 checkbank); > > > > I would think of splitting this change. Like in a separate patch you > > simply > > create this interface and only add what you need in the next one. > > Can do, though I didn't feel you were particularly fussed about me > having split that out...
Oh, it just would be cleaner to see what you have done for a new chip support. Up to you and maintainers.
-- With Best Regards, Andy Shevchenko
| |