lkml.org 
[lkml]   [2022]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v4 5/8] EDAC/ghes: Make ghes_edac a proper module to remove the dependency on ghes
    Date
    Hi Kani
    As per your review for previous patches, I will update the commit log in the next version.
    Please see my comments below:

    > -----Original Message-----
    > > @@ -454,7 +437,7 @@ int ghes_edac_register(struct ghes *ghes, struct
    > > device *dev)
    > > pr_info("This system has a very crappy BIOS: It doesn't even list
    > > the DIMMS.\n");
    > > pr_info("Its SMBIOS info is wrong. It is doubtful that the error
    > > report would\n");
    > > pr_info("work on such system. Use this driver with caution\n");
    > > - } else if (idx < 0) {
    > > + } else if (ghes_edac_force_load) {
    >
    > This change causes the following messages to start showing up on Arm.
    > Is that what you intend to do?
    >
    No

    > The messages can be avoided by not setting the force flag on Arm
    > unconditionally.
    > This will need some change to the flag check in ghes_edac_unregister() though.
    Yes, looks like I can remove the ghes_edac_force_load check in the ghes_edac_unregister()
    since it had been checked in the ghes_edac_init


    \
     
     \ /
      Last update: 2022-09-05 16:36    [W:3.162 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site