Messages in this thread | | | From | "Gupta, Nipun" <> | Subject | RE: [RFC PATCH v2 6/6] driver core: add compatible string in sysfs for platform devices | Date | Mon, 5 Sep 2022 13:54:54 +0000 |
| |
[AMD Official Use Only - General]
> -----Original Message----- > From: Saravana Kannan <saravanak@google.com> > Sent: Wednesday, August 17, 2022 9:34 PM > To: Greg KH <gregkh@linuxfoundation.org> > Cc: Gupta, Nipun <Nipun.Gupta@amd.com>; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; rafael@kernel.org; eric.auger@redhat.com; > alex.williamson@redhat.com; cohuck@redhat.com; Gupta, Puneet (DCG-ENG) > <puneet.gupta@amd.com>; song.bao.hua@hisilicon.com; > mchehab+huawei@kernel.org; maz@kernel.org; f.fainelli@gmail.com; > jeffrey.l.hugo@gmail.com; Michael.Srba@seznam.cz; mani@kernel.org; > yishaih@nvidia.com; jgg@ziepe.ca; linux-kernel@vger.kernel.org; > devicetree@vger.kernel.org; kvm@vger.kernel.org; okaya@kernel.org; Anand, > Harpreet <harpreet.anand@amd.com>; Agarwal, Nikhil > <nikhil.agarwal@amd.com>; Simek, Michal <michal.simek@amd.com>; git > (AMD-Xilinx) <git@amd.com> > Subject: Re: [RFC PATCH v2 6/6] driver core: add compatible string in sysfs for > platform devices > > [CAUTION: External Email] > > On Wed, Aug 17, 2022 at 8:31 AM Greg KH <gregkh@linuxfoundation.org> > wrote: > > > > On Wed, Aug 17, 2022 at 08:35:42PM +0530, Nipun Gupta wrote: > > > This change adds compatible string for the platform based > > > devices. > > > > What exactly is a "compatible string"? > > Didn't read the rest of the patches in the series yet, but Nack to > this. This info is already available under: > > <device folder>/of_node/compatible for any device in any (or at least > most) bus that was created from an of_node. > > Unless compatible is now also in ACPI. In which case, it's probably be > better to have an of_node like symlink.
We will not be going with platform devices for CDX bus and would rather have CDX devices: https://lore.kernel.org/lkml/DM6PR12MB30827577D50AB1B877458923E8799@DM6PR12MB3082.namprd12.prod.outlook.com/ So, this change is not valid for us. We would not be having this in Rev V3.
- Nipun
| |