lkml.org 
[lkml]   [2022]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v1 01/11] PCI: tegra: switch to using devm_fwnode_gpiod_get
On Mon, Sep 5, 2022 at 10:23 AM Pali Rohár <pali@kernel.org> wrote:
> On Sunday 04 September 2022 23:30:53 Dmitry Torokhov wrote:

...

> > - rp->reset_gpio = devm_gpiod_get_from_of_node(dev, port,
> > - "reset-gpios", 0,
> > - GPIOD_OUT_LOW,
> > - label);
> > + rp->reset_gpio = devm_fwnode_gpiod_get(dev,
> > + of_fwnode_handle(port),
> > + "reset",
> > + GPIOD_OUT_LOW,
> > + label);
>
> Why in pci-aardvark.c for PERST# reset-gpio you have used
> devm_gpiod_get_optional() and here in pci-tegra.c you have used
> devm_fwnode_gpiod_get()? I think that PERST# logic is same in both
> drivers.

It's not the same dev and its node in this case. There is one reset
for _all_ ports, here is the reset on _per port_ basis.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2022-09-17 16:27    [W:0.109 / U:0.520 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site