lkml.org 
[lkml]   [2022]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V8 4/6] soc: imx: add i.MX93 media blk ctrl driver
On Mon, Sep 05, 2022 at 02:47:16PM +0800, Peng Fan wrote:
[...]
> > > +struct imx93_blk_ctrl_data {
> > > + const struct imx93_blk_ctrl_domain_data *domains;
> > > + const struct imx93_blk_ctrl_domain_data *bus;
> >
> > It looks confusing to claim 'bus' as an imx93_blk_ctrl_domain_data. I
> > would suggest you have 'related' fields directly defined in
> > imx93_blk_ctrl_data.
>
> This would implies a bit large change to this driver.
>
> Should I use a new V1 for the patchset or continue V9 for next version?

I think v9 is fine.

Shawn

\
 
 \ /
  Last update: 2022-09-06 04:10    [W:0.096 / U:2.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site