lkml.org 
[lkml]   [2022]   [Sep]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] driver core: fix driver_set_override() issue with empty strings
From
On 01/09/2022 19:37, Greg Kroah-Hartman wrote:
> Python likes to send an empty string for some sysfs files, including the
> driver_override field. When commit 23d99baf9d72 ("PCI: Use
> driver_set_override() instead of open-coding") moved the PCI core to use
> the driver core function instead of hand-rolling their own handler, this
> showed up as a regression from some userspace tools, like DPDK.
>
> Fix this up by actually looking at the length of the string first
> instead of trusting that userspace got it correct.
>
> Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> Fixes: 23d99baf9d72 ("PCI: Use driver_set_override() instead of open-coding")
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: stable <stable@kernel.org>
> Tested-by: Huisong Li <lihuisong@huawei.com>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-09-05 08:38    [W:0.060 / U:0.184 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site