lkml.org 
[lkml]   [2022]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v7 11/15] mei: gsc: setup gsc extended operational memory
Date
> > +static void pxp_is_ready(struct mei_cl_device *cldev)
> > +{
> > + struct mei_device *bus = cldev->bus;
> > +
> > + switch (bus->pxp_mode) {
> > + case MEI_DEV_PXP_READY:
> > + case MEI_DEV_PXP_DEFAULT:
> > + cldev->do_match = 1;
>
> Can you explain why you set do_match = 1 with MEI_DEV_PXP_DEFAULT ?
> AFAIU MEI_DEV_PXP_DEFAULT means that we haven't even started to
> initialize PXP, so it seems weird to match in that scenario.
>
> Apart from this, the patch LGTM.
>
> Daniele

MEI_DEV_PXP_DEFAULT is a state for the legacy PXP solution that uses the same firmware client
and have no need in special initialization.

--
Thanks,
Sasha


\
 
 \ /
  Last update: 2022-09-04 09:31    [W:0.654 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site