lkml.org 
[lkml]   [2022]   [Sep]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] arm64: dts: qcom: sc8280xp-pmics: Remove reg entry for pmc8280c_lpg node
    On 03/09/2022 11:44, Bhupesh Sharma wrote:
    > Commit eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration")
    > dropped PWM reg declaration for pm8350c pwm(s), but there is a leftover
    > 'reg' entry inside the lpg/pwm node in sc8280xp dts file. Remove the same.
    >
    > While at it, also remove the unused unit address in the node
    > label.
    >
    > Fixes: eeca7d46217c ("arm64: dts: qcom: pm8350c: Drop PWM reg declaration")
    > Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
    > Cc: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
    > Cc: Bjorn Andersson <andersson@kernel.org>
    > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
    > ---
    > arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi | 3 +--
    > 1 file changed, 1 insertion(+), 2 deletions(-)
    >
    > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
    > index ae90b97aecb8..2e5cf55afdd5 100644
    > --- a/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
    > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-pmics.dtsi
    > @@ -60,9 +60,8 @@ pmc8280c_gpios: gpio@8800 {
    > #interrupt-cells = <2>;
    > };
    >
    > - pmc8280c_lpg: lpg@e800 {
    > + pmc8280c_lpg: lpg {

    I wonder why I did not see the errors when testing all DTSes for
    https://lore.kernel.org/all/20220828084341.112146-9-krzysztof.kozlowski@linaro.org/

    Anyway, it cannot be lpg - binding requires "pwm".

    Best regards,
    Krzysztof

    Best regards,
    Krzysztof

    \
     
     \ /
      Last update: 2022-09-04 21:23    [W:5.075 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site